Change in pysim[master]: Add decoder/encoder for EF.SUCI_Calc_Info

fixeria gerrit-no-reply at lists.osmocom.org
Thu Apr 1 14:43:47 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23564 )

Change subject: Add decoder/encoder for EF.SUCI_Calc_Info
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py 
File tests/test_utils.py:

https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py@95 
PS1, Line 95: 0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1
I would move this and the other key into separate [class] variables, so there would be no need to repeat it here and there:

  HNET_PUBKEY27 = '...'
  HNET_PUBKEY30 = '...'
  FILE = '...' + HNET_PUBKEY27 + '...' + HNET_PUBKEY30

  def testFoo(self):
    ...

  def testBar(self):
    ...



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I848a766e6d00be497c7db905475e0681cce197ac
Gerrit-Change-Number: 23564
Gerrit-PatchSet: 1
Gerrit-Owner: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Apr 2021 14:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/37cd5fa0/attachment.htm>


More information about the gerrit-log mailing list