Change in pysim[master]: Add decoder/encoder for EF.SUCI_Calc_Info

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 1 15:19:42 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23564 )

Change subject: Add decoder/encoder for EF.SUCI_Calc_Info
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23564/1/pySim/ts_31_102.py 
File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/23564/1/pySim/ts_31_102.py@301 
PS1, Line 301: 			out_bytes.append(0x01) # TODO size, fixed to 1 byte
this manual TLV encoding/decoding works, but is of course quite a bit of a hack.  we traditionally used pytlv for decoding, but @dexter has been proposing to move to uttlv.  However, even that is not a proper BER-TLV encoder/decoder.

We can merge this as-is, but in case you are working on more related code, I think now would be a good time to settle on a new TLV encoder/decoder before introducing more hand-crafted hacks.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I848a766e6d00be497c7db905475e0681cce197ac
Gerrit-Change-Number: 23564
Gerrit-PatchSet: 1
Gerrit-Owner: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 15:19:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/6f94a613/attachment.htm>


More information about the gerrit-log mailing list