<p><a href="https://gerrit.osmocom.org/c/pysim/+/23564">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py">File tests/test_utils.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23564/1/tests/test_utils.py@95">Patch Set #1, Line 95:</a> <code style="font-family:monospace,monospace">0272DA71976234CE833A6907425867B82E074D44EF907DFB4B3E21C1C2256EBCD1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would move this and the other key into separate [class] variables, so there would be no need to repeat it here and there:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  HNET_PUBKEY27 = '...'<br>  HNET_PUBKEY30 = '...'<br>  FILE = '...' + HNET_PUBKEY27 + '...' + HNET_PUBKEY30</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  def testFoo(self):<br>    ...</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  def testBar(self):<br>    ...</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23564">change 23564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I848a766e6d00be497c7db905475e0681cce197ac </div>
<div style="display:none"> Gerrit-Change-Number: 23564 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: merlinchlosta <merlin.chlosta@rub.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Apr 2021 14:43:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>