This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16162 ) Change subject: vty: track parent nodes also for telnet sessions ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/16162/2/include/osmocom/vty/vty.h File include/osmocom/vty/vty.h: https://gerrit.osmocom.org/c/libosmocore/+/16162/2/include/osmocom/vty/vty.h@189 PS2, Line 189: int (*is_config_node)(struct vty *vty, int node); worth checking if a field in a struct can be marked as deprecated. https://gerrit.osmocom.org/c/libosmocore/+/16162/2/src/vty/command.c File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/16162/2/src/vty/command.c@2361 PS2, Line 2361: llist_add(&parent->entry, &vty->parent_nodes); Don't you need to initialize ->entry beforehand? or having it set to 0 is fine? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2b32b4fe20732728db6e9cdac7e484d96ab86dc5 Gerrit-Change-Number: 16162 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2019 14:44:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191122/44b223e6/attachment.htm>