<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16162">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16162/2/include/osmocom/vty/vty.h">File include/osmocom/vty/vty.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/16162/2/include/osmocom/vty/vty.h@189">Patch Set #2, Line 189:</a> <code style="font-family:monospace,monospace">       int (*is_config_node)(struct vty *vty, int node);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">worth checking if a field in a struct can be marked as deprecated.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16162/2/src/vty/command.c">File src/vty/command.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/16162/2/src/vty/command.c@2361">Patch Set #2, Line 2361:</a> <code style="font-family:monospace,monospace">                  llist_add(&parent->entry, &vty->parent_nodes);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Don't you need to initialize ->entry beforehand? or having it set to 0 is fine?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16162">change 16162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16162"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b32b4fe20732728db6e9cdac7e484d96ab86dc5 </div>
<div style="display:none"> Gerrit-Change-Number: 16162 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 22 Nov 2019 14:44:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>