Change in libosmocore[master]: vty: track parent nodes also for telnet sessions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Nov 24 18:43:34 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16162 )

Change subject: vty: track parent nodes also for telnet sessions
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/16162/2/src/vty/command.c 
File src/vty/command.c:

https://gerrit.osmocom.org/c/libosmocore/+/16162/2/src/vty/command.c@2361 
PS2, Line 2361: 			llist_add(&parent->entry, &vty->parent_nodes);
> Don't you need to initialize ->entry beforehand? or having it set to 0 is fine?
INIT_LLIST_HEAD() is only needed for a list's head, not for the entries added to it.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16162
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2b32b4fe20732728db6e9cdac7e484d96ab86dc5
Gerrit-Change-Number: 16162
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 24 Nov 2019 18:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191124/6479d276/attachment.htm>


More information about the gerrit-log mailing list