Change in osmo-msc[master]: build osmo-msc: add "missing" LIBASN1C_LIBS

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 19 07:25:04 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/7306 )

Change subject: build osmo-msc: add "missing" LIBASN1C_LIBS
......................................................................

build osmo-msc: add "missing" LIBASN1C_LIBS

in osmo-msc/Makefile.am, osmo-msc was actually missing the LIBASN1C_LIBS even
though it included LIBASN1C_CFLAGS. Probably libasn1c is implicitly linked from
libranap.so, but doesn't hurt to name it.

When building without Iu support, the LIBOSMORANAP* and LIBASN1C* vars are
empty, so no need to explicitly switch on BUILD_IU, just name them.

Change-Id: I39ae5e3f0f7661ca9ee5c17a500be28c461d7ec7
---
M src/osmo-msc/Makefile.am
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-msc/Makefile.am b/src/osmo-msc/Makefile.am
index 9b54716..7b56c74 100644
--- a/src/osmo-msc/Makefile.am
+++ b/src/osmo-msc/Makefile.am
@@ -43,15 +43,11 @@
 	$(LIBOSMOABIS_LIBS) \
 	$(LIBOSMONETIF_LIBS) \
 	$(LIBSMPP34_LIBS) \
+	$(LIBOSMORANAP_LIBS) \
+	$(LIBASN1C_LIBS) \
 	$(LIBOSMOSIGTRAN_LIBS) \
 	$(LIBOSMOMGCPCLIENT_LIBS) \
 	$(LIBOSMOGSUPCLIENT_LIBS) \
 	-ldbi \
 	-lsctp \
 	$(NULL)
-if BUILD_IU
-osmo_msc_LDADD += \
-	$(LIBASN1C_LIBS) \
-	$(LIBOSMORANAP_LIBS) \
-	$(NULL)
-endif

-- 
To view, visit https://gerrit.osmocom.org/7306
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39ae5e3f0f7661ca9ee5c17a500be28c461d7ec7
Gerrit-Change-Number: 7306
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190519/fa58ef77/attachment.html>


More information about the gerrit-log mailing list