Change in osmo-trx[master]: transceiver: RSSI was calculated reverse.

tnt gerrit-no-reply at lists.osmocom.org
Fri May 10 10:32:00 UTC 2019


tnt has posted comments on this change. ( https://gerrit.osmocom.org/9598 )

Change subject: transceiver: RSSI was calculated reverse.
......................................................................


Patch Set 2:

The 'RSSI' definitely seems to be 'opposite' logic ... not sure why.
But the field in the 'TX' path is also the same, see line 360 during the  scaling. Other parts seem to be as well. (see the noise math a bit below). It seems all pretty confusing and I don't really see why.

My only guess would be that someone wanted a uint8_t on the wire with '0' begin the 'max' and rising value meaning smaller signals received / transmitted. But then at someother point variables are named dBm (which it's definitely not).

I'm not sure if there is a document that specifies exactly what we want on the trx interface ?


-- 
To view, visit https://gerrit.osmocom.org/9598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa4eda4660dbe155ac1c782b77316ef504ef00c5
Gerrit-Change-Number: 9598
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Fri, 10 May 2019 10:32:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/26129f3e/attachment.html>


More information about the gerrit-log mailing list