<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/7306">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">build osmo-msc: add "missing" LIBASN1C_LIBS<br><br>in osmo-msc/Makefile.am, osmo-msc was actually missing the LIBASN1C_LIBS even<br>though it included LIBASN1C_CFLAGS. Probably libasn1c is implicitly linked from<br>libranap.so, but doesn't hurt to name it.<br><br>When building without Iu support, the LIBOSMORANAP* and LIBASN1C* vars are<br>empty, so no need to explicitly switch on BUILD_IU, just name them.<br><br>Change-Id: I39ae5e3f0f7661ca9ee5c17a500be28c461d7ec7<br>---<br>M src/osmo-msc/Makefile.am<br>1 file changed, 2 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-msc/Makefile.am b/src/osmo-msc/Makefile.am</span><br><span>index 9b54716..7b56c74 100644</span><br><span>--- a/src/osmo-msc/Makefile.am</span><br><span>+++ b/src/osmo-msc/Makefile.am</span><br><span>@@ -43,15 +43,11 @@</span><br><span>      $(LIBOSMOABIS_LIBS) \</span><br><span>        $(LIBOSMONETIF_LIBS) \</span><br><span>       $(LIBSMPP34_LIBS) \</span><br><span style="color: hsl(120, 100%, 40%);">+   $(LIBOSMORANAP_LIBS) \</span><br><span style="color: hsl(120, 100%, 40%);">+        $(LIBASN1C_LIBS) \</span><br><span>   $(LIBOSMOSIGTRAN_LIBS) \</span><br><span>     $(LIBOSMOMGCPCLIENT_LIBS) \</span><br><span>  $(LIBOSMOGSUPCLIENT_LIBS) \</span><br><span>  -ldbi \</span><br><span>      -lsctp \</span><br><span>     $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-if BUILD_IU</span><br><span style="color: hsl(0, 100%, 40%);">-osmo_msc_LDADD += \</span><br><span style="color: hsl(0, 100%, 40%);">-   $(LIBASN1C_LIBS) \</span><br><span style="color: hsl(0, 100%, 40%);">-      $(LIBOSMORANAP_LIBS) \</span><br><span style="color: hsl(0, 100%, 40%);">-  $(NULL)</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/7306">change 7306</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/7306"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I39ae5e3f0f7661ca9ee5c17a500be28c461d7ec7 </div>
<div style="display:none"> Gerrit-Change-Number: 7306 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>