Change in osmo-msc[master]: vty: make retrieve-imeisv-early configurable

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue May 7 10:50:05 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13892 )

Change subject: vty: make retrieve-imeisv-early configurable
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c@465
PS1, Line 465:       "Retrieve the IMEISV from the MS before doing the location update. In combination with other MSC and HLR"
I think "accepting" or "concluding" location update makes more sense here instead of "before".


https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c@470
PS1, Line 470:       "Do not retrieve IMEISV before location update\n")
I think these two lines should be swapped.


Actually, I think you should move into "retrieve-imeisv-early" and "no retrieve-imeisv-early" commands, being no the default.


https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c@552
PS1, Line 552: 		vty_out(vty, " retrieve-imeisv-early 1 %s",
See my comment about adding the "no retrieve-imeisv-early" command.



-- 
To view, visit https://gerrit.osmocom.org/13892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I256224194c3b8caf2b58a88d11dccd32c569201f
Gerrit-Change-Number: 13892
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 10:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/cc5cc25e/attachment.html>


More information about the gerrit-log mailing list