Change in osmo-msc[master]: vty: make retrieve-imeisv-early configurable

osmith gerrit-no-reply at lists.osmocom.org
Tue May 7 10:05:44 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13892


Change subject: vty: make retrieve-imeisv-early configurable
......................................................................

vty: make retrieve-imeisv-early configurable

Prepare for Rhizomatica's subscriber on demand use case, in which the
network access is disabled by default for new subscribers, but the IMEI
is required in the HLR to find out which user has which IMSI. Due to the
network access being disabled, the location update fails and the MS gets
rejected, so we need to get the IMEI early.

The OsmoHLR documentation referenced in the code will be added in
osmo-hlr.git's Change-Id I2dd4a56f7b8be8b5d0e6fc32e04459e5e278d0a9.

Related: OS#2542
Change-Id: I256224194c3b8caf2b58a88d11dccd32c569201f
---
M src/libmsc/msc_vty.c
M tests/test_nodes.vty
2 files changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/13892/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 9bc8f3a..cce8aac 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -460,6 +460,19 @@
 	return CMD_SUCCESS;
 }
 
+DEFUN(cfg_msc_retrieve_imeisv_early, cfg_msc_retrieve_imeisv_early_cmd,
+      "retrieve-imeisv-early (0|1)",
+      "Retrieve the IMEISV from the MS before doing the location update. In combination with other MSC and HLR"
+      " configuration, this allows sending the IMEI to the HLR, even if the MS would get rejected in the location"
+      " update. To set this up with OsmoHLR, see the \"Configuring the Subscribers Create on Demand Feature\" section"
+      " of the OsmoHLR user manual.\n"
+      "Retrieve IMEISV before location update\n"
+      "Do not retrieve IMEISV before location update\n")
+{
+	gsmnet->vlr->cfg.retrieve_imeisv_early = atoi(argv[0]) ? true : false;
+	return CMD_SUCCESS;
+}
+
 DEFUN(cfg_msc_paging_response_timer, cfg_msc_paging_response_timer_cmd,
       "paging response-timer (default|<1-65535>)",
       "Configure Paging\n"
@@ -535,6 +548,10 @@
 		vty_out(vty, " check-imei-rqd 1 %s",
 			VTY_NEWLINE);
 
+	if (gsmnet->vlr->cfg.retrieve_imeisv_early)
+		vty_out(vty, " retrieve-imeisv-early 1 %s",
+			VTY_NEWLINE);
+
 	if (gsmnet->paging_response_timer != MSC_PAGING_RESPONSE_TIMER_DEFAULT)
 		vty_out(vty, " paging response-timer %u%s", gsmnet->paging_response_timer, VTY_NEWLINE);
 
@@ -1686,6 +1703,7 @@
 	install_element(MSC_NODE, &cfg_msc_auth_tuple_max_reuse_count_cmd);
 	install_element(MSC_NODE, &cfg_msc_auth_tuple_reuse_on_error_cmd);
 	install_element(MSC_NODE, &cfg_msc_check_imei_rqd_cmd);
+	install_element(MSC_NODE, &cfg_msc_retrieve_imeisv_early_cmd);
 	install_element(MSC_NODE, &cfg_msc_cs7_instance_a_cmd);
 	install_element(MSC_NODE, &cfg_msc_cs7_instance_iu_cmd);
 	install_element(MSC_NODE, &cfg_msc_paging_response_timer_cmd);
diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index 8aceb86..7996ace 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -39,6 +39,7 @@
   auth-tuple-max-reuse-count <-1-2147483647>
   auth-tuple-reuse-on-error (0|1)
   check-imei-rqd (0|1)
+  retrieve-imeisv-early (0|1)
   cs7-instance-a <0-15>
   cs7-instance-iu <0-15>
   paging response-timer (default|<1-65535>)

-- 
To view, visit https://gerrit.osmocom.org/13892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I256224194c3b8caf2b58a88d11dccd32c569201f
Gerrit-Change-Number: 13892
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/e6f758df/attachment-0001.html>


More information about the gerrit-log mailing list