Change in osmo-msc[master]: vty: make retrieve-imeisv-early configurable

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 7 12:43:50 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13892 )

Change subject: vty: make retrieve-imeisv-early configurable
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c@464
PS1, Line 464: retrieve-imeisv-early
Is this command related to 'check-imei-rqd' anyhow? If yes, it would make sense to merge this one as a flag of the existing command, i.e.: "check-imei-rqd (0|1) [early]".


https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c@465
PS1, Line 465:       "Retrieve the IMEISV from the MS before doing the location update. In combination with other MSC and HLR"
> I think "accepting" or "concluding" location update makes more sense here instead of "before".
ACK


https://gerrit.osmocom.org/#/c/13892/1/src/libmsc/msc_vty.c@470
PS1, Line 470:       "Do not retrieve IMEISV before location update\n")
> I think these two lines should be swapped.

ACK.

> I think you should move into "retrieve-imeisv-early" and "no retrieve-imeisv-early" [...]

Well, 'check-imei-rqd' is already using (0|1), so using the suggested approach would increase the inconsistency.



-- 
To view, visit https://gerrit.osmocom.org/13892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I256224194c3b8caf2b58a88d11dccd32c569201f
Gerrit-Change-Number: 13892
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 12:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190507/c53a2542/attachment.html>


More information about the gerrit-log mailing list