Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 19 13:20:28 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13067 )

Change subject: MCS: move HeaderType enum outside of class definition
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.c
File src/coding_scheme.c:

https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.c@43
PS7, Line 43: uint8_t num_data_blocks(enum HeaderType ht)
            : {
            : 	return hdr_type_info[ht].num_blocks;
            : }
            : 
            : uint8_t num_data_header_bits_UL(enum HeaderType ht)
            : {
            : 	return hdr_type_info[ht].uplink.data_header_bits;
            : }
            : 
            : uint8_t num_data_header_bits_DL(enum HeaderType ht)
            : {
            : 	return hdr_type_info[ht].downlink.data_header_bits;
            : }
            : 
            : uint8_t num_data_block_header_bits(enum HeaderType ht)
            : {
            : 	return hdr_type_info[ht].data_block_header_bits;
            : }
none of those functions protect against array out-of-index access.



-- 
To view, visit https://gerrit.osmocom.org/13067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f
Gerrit-Change-Number: 13067
Gerrit-PatchSet: 7
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2019 13:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190319/cf25ae97/attachment.html>


More information about the gerrit-log mailing list