Change in osmo-pcu[master]: MCS: move HeaderType enum outside of class definition

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Mar 13 19:23:34 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13067 )

Change subject: MCS: move HeaderType enum outside of class definition
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h
File src/coding_scheme.h:

https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.h@44
PS7, Line 44: uint8_t num_data_header_bits_UL(enum HeaderType ht);
> That's the whole point :) […]
I didn't know possibility of writing typos was lower when using caps, I'd be glad to see some scientific study probing that ;-)



-- 
To view, visit https://gerrit.osmocom.org/13067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f
Gerrit-Change-Number: 13067
Gerrit-PatchSet: 7
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 19:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/27a2f57d/attachment.html>


More information about the gerrit-log mailing list