<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/13067">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.c">File src/coding_scheme.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13067/7/src/coding_scheme.c@43">Patch Set #7, Line 43:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">uint8_t num_data_blocks(enum HeaderType ht)<br>{<br>     return hdr_type_info[ht].num_blocks;<br>}<br><br>uint8_t num_data_header_bits_UL(enum HeaderType ht)<br>{<br>     return hdr_type_info[ht].uplink.data_header_bits;<br>}<br><br>uint8_t num_data_header_bits_DL(enum HeaderType ht)<br>{<br>        return hdr_type_info[ht].downlink.data_header_bits;<br>}<br><br>uint8_t num_data_block_header_bits(enum HeaderType ht)<br>{<br>   return hdr_type_info[ht].data_block_header_bits;<br>}<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">none of those functions protect against array out-of-index access.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13067">change 13067</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13067"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id0873f85e1f16a72e17e7fbc4ad76b194917067f </div>
<div style="display:none"> Gerrit-Change-Number: 13067 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Mar 2019 13:20:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>