Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 13 21:20:09 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13232 )

Change subject: vty: Ensure to properly save route pointcode and mask when writing
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13232/2/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/#/c/13232/2/src/osmo_ss7_vty.c@365
PS2, Line 365: 			osmo_ss7_pointcode_print2(rtable->inst, rt->cfg.mask),
> I really don't like having this "2" API with a different static buffer instead of simply copying it  […]
I also don't like it and would very much prefer my "volatile select loop iteration talloc context" approach.  However, the existing code works that way and it is out of scope for this patch



-- 
To view, visit https://gerrit.osmocom.org/13232
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012
Gerrit-Change-Number: 13232
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Mar 2019 21:20:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/27437df5/attachment.html>


More information about the gerrit-log mailing list