Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 13 21:20:12 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13232 )

Change subject: vty: Ensure to properly save route pointcode and mask when writing
......................................................................

vty: Ensure to properly save route pointcode and mask when writing

As osmo_ss7_route_print() returns a static buffer, we cannot use it
twice within a single log/print statement.  Rather, we must use
osmo_ss7_route_print2() for the second call, as it uses a separate
static buffer.

Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012
---
M src/osmo_ss7_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 1b7bcb9..950eb08 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -362,7 +362,7 @@
 	llist_for_each_entry(rt, &rtable->routes, list) {
 		vty_out(vty, "  update route %s %s linkset %s",
 			osmo_ss7_pointcode_print(rtable->inst, rt->cfg.pc),
-			osmo_ss7_pointcode_print(rtable->inst, rt->cfg.mask),
+			osmo_ss7_pointcode_print2(rtable->inst, rt->cfg.mask),
 			rt->cfg.linkset_name);
 		if (rt->cfg.priority)
 			vty_out(vty, " priority %u", rt->cfg.priority);

-- 
To view, visit https://gerrit.osmocom.org/13232
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012
Gerrit-Change-Number: 13232
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/d1e4b6dd/attachment.htm>


More information about the gerrit-log mailing list