Change in libosmo-sccp[master]: vty: Ensure to properly save route pointcode and mask when writing

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 13 15:51:11 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13232 )

Change subject: vty: Ensure to properly save route pointcode and mask when writing
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

I agree that *2() is confusing as it's used for both '2nd version' and '2nd call' but cleaning that is out of scope of this patch indeed.

https://gerrit.osmocom.org/#/c/13232/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13232/1//COMMIT_MSG@7
PS1, Line 7: vty: Ensure to properly save route pointcode and mask when writing
> I'm of course referring to "Maksim" which is IIRC closer to the cyrillic original of Maxim. […]
Yepp, Максим it is :)



-- 
To view, visit https://gerrit.osmocom.org/13232
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica32e83cbe8af2317cb07f8d8422a399fa537012
Gerrit-Change-Number: 13232
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Mar 2019 15:51:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190313/42a3ed53/attachment.html>


More information about the gerrit-log mailing list