Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 23 08:47:23 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 )

Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> why would osmo-bts-trx not always want to request the highest locally supported version and in the end chose  whatever the highest the TRX supports?

I can think of several scenarios:
* Because TRX in the set up has a bug when using that higher version of the protocol, or sends incorrect data. This allows to still have a running set up with a lower working/more tested version of the protocol.
* Because TRX may not support SETFORMAT and fail to continue upon receival of that command (like SC5 TRX implementation). This way, if "osmotrx trxd-max-version 0" is used, no SETFORMAT is sent (because 0 is the default starting version for backward compatibility).

> 
> I think this vty command may actually be dangerous, in that it will persist software upgrades in your config file.  This means you update e.g.both your trx and osmo-bts (which could provide better features/performance/...), but you will still use some old version as you have that statement in your config file.

I think it's fine, since you may want to stick to that version for reasons explained above (specially deployed in the field, it could be your TRX is never updated). I can add a notice log when using "osmotrx trxd-max-version" with version different than highest if you like.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 23 Jul 2019 08:47:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190723/75c1be61/attachment.html>


More information about the gerrit-log mailing list