Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 22 20:48:47 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 )

Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c 
File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c@502 
PS2, Line 502: -1
Somehow this '-1' on the VTY doesn't look like a good idea to me.

Something like:

  "osmotrx trxd-max-version (max|legacy)",
  "osmotrx trxd-max-version <1-15>",

looks intuitive and more elegant. This way a user doesn't need to know which version is the legacy one (0).


https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c@510 
PS2, Line 510: %d is not supported
As a user, I would expect to see which one _is supported_ then (basically the maximum, "... %d\n" % TRX_DATA_FORMAT_VER).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 22 Jul 2019 20:48:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190722/4bf3ee48/attachment.html>


More information about the gerrit-log mailing list