Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 23 08:49:49 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 )

Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c 
File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c@502 
PS2, Line 502: -1
> Somehow this '-1' on the VTY doesn't look like a good idea to me. […]
And later on, when we have version 2, there will be 2 legacy ones, 0 and 1. What are you going to do then?
I'm sorry but I'm not liking your proposal either, i looks confusing to me.

What I could do:
  "osmotrx trxd-max-version latest",
  "osmotrx trxd-max-version <0-15>",

so see I changed -1 with "latest". Fine with it?


https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c@510 
PS2, Line 510: %d is not supported
> As a user, I would expect to see which one _is supported_ then (basically the maximum, "... […]
Fine, I'll print that too.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326
Gerrit-Change-Number: 14896
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 23 Jul 2019 08:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190723/cea6e91c/attachment.html>


More information about the gerrit-log mailing list