This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 Change subject: mncc: do not unregister unregistered osmo fds ...................................................................... mncc: do not unregister unregistered osmo fds The function close_connection() calls osmo_fd_unregister() without checking if the osmo_fd is registered at all. Lets make sure the osmo_fs is registered by checking it using osmo_fd_unregister() Related: OS#4159 Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e --- M src/mncc.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/03/15303/1 diff --git a/src/mncc.c b/src/mncc.c index e23bd6f..63e4faa 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -324,7 +324,8 @@ /* Close the MNCC connection/socket */ static void close_connection(struct mncc_connection *conn) { - osmo_fd_unregister(&conn->fd); + if (osmo_fd_is_registered(&conn->fd)) + osmo_fd_unregister(&conn->fd); close(conn->fd.fd); osmo_timer_schedule(&conn->reconnect, 5, 0); conn->state = MNCC_DISCONNECTED; -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e Gerrit-Change-Number: 15303 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190828/0ee27f2c/attachment.htm>