Change in ...osmo-ggsn[master]: cosmetic: fix formatting in if line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 29 11:36:10 UTC 2019


pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15302 )

Change subject: cosmetic: fix formatting in if line
......................................................................

cosmetic: fix formatting in if line

Fixes: eefa30dce8fa8e0ae16a3108e23041f92ea6ab21
Fixes: 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6
Change-Id: I9ee5f4142cacf912145693c72a53c0f531bad2c6
---
M ggsn/ggsn.c
M gtp/pdp.c
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 89b183f..7b32bde 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -358,8 +358,9 @@
 			member = pdp->peer[i];
 			send_trap(gsn, pdp, member, "imsi-rem-ip"); /* TRAP with IP removal */
 			ippool_freeip(member->pool, member);
-		} else if(i == 0)
+		} else if (i == 0) {
 			LOGPPDP(LOGL_ERROR, pdp, "Cannot find/free IP Pool member\n");
+		}
 	}
 
 	if (!pdp_priv) {
diff --git a/gtp/pdp.c b/gtp/pdp.c
index 739cf73..518f5d4 100644
--- a/gtp/pdp.c
+++ b/gtp/pdp.c
@@ -109,7 +109,7 @@
 
 int pdp_init(struct gsn_t *gsn)
 {
-	if(!g_gsn) {
+	if (!g_gsn) {
 		g_gsn = gsn;
 	} else {
 		LOGP(DLGTP, LOGL_FATAL, "This interface is depreacted and doesn't support multiple GGSN!");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9ee5f4142cacf912145693c72a53c0f531bad2c6
Gerrit-Change-Number: 15302
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/63bd4be0/attachment.htm>


More information about the gerrit-log mailing list