<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mncc: do not unregister unregistered osmo fds<br><br>The function close_connection() calls osmo_fd_unregister() without<br>checking if the osmo_fd is registered at all. Lets make sure the osmo_fs<br>is registered by checking it using osmo_fd_unregister()<br><br>Related: OS#4159<br>Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e<br>---<br>M src/mncc.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/03/15303/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index e23bd6f..63e4faa 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -324,7 +324,8 @@</span><br><span> /* Close the MNCC connection/socket */</span><br><span> static void close_connection(struct mncc_connection *conn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       osmo_fd_unregister(&conn->fd);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (osmo_fd_is_registered(&conn->fd))</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_fd_unregister(&conn->fd);</span><br><span>        close(conn->fd.fd);</span><br><span>       osmo_timer_schedule(&conn->reconnect, 5, 0);</span><br><span>  conn->state = MNCC_DISCONNECTED;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303">change 15303</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15303"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9742f31a37296fed15d54cf44c1f65b93abb8c8e </div>
<div style="display:none"> Gerrit-Change-Number: 15303 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>