Change in ...osmo-bsc[master]: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()

fixeria gerrit-no-reply at lists.osmocom.org
Fri Aug 23 14:45:42 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277


Change subject: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()
......................................................................

abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC()

The LOGPC() is usually used for continuation when printing complex
logging messages (e.g. where using format string is not enough).
In this case, nothing is being printed before calling LOGPC(), so
the logging messages appear without the meta info (time-stamp,
level, category, etc.), for example:

  BTS 0 reported connected PCU version 0.7.0.1-2585-dirty

Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563
---
M src/osmo-bsc/abis_nm.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/15277/1

diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 7d059b5..b12ba43 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -341,10 +341,10 @@
 	switch (cause) {
 	case OSMO_EVT_PCU_VERS:
 		if (text) {
-			LOGPC(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text);
+			LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text);
 			osmo_strlcpy(bts->pcu_version, text, sizeof(bts->pcu_version));
 		} else {
-			LOGPC(DNM, LOGL_ERROR, "BTS %u reported PCU disconnection.\n", bts->nr);
+			LOGP(DNM, LOGL_ERROR, "BTS %u reported PCU disconnection.\n", bts->nr);
 			bts->pcu_version[0] = '\0';
 		}
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563
Gerrit-Change-Number: 15277
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/d9c483ee/attachment.html>


More information about the gerrit-log mailing list