Change in ...osmo-bsc[master]: lchan_select.c: tune log level in lchan_select_by_type()

laforge gerrit-no-reply at lists.osmocom.org
Tue Aug 27 12:10:47 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15276 )

Change subject: lchan_select.c: tune log level in lchan_select_by_type()
......................................................................

lchan_select.c: tune log level in lchan_select_by_type()

If lchan_select_by_type() fails to find a suitable logical channel,
it would print a message using LOGL_ERROR. This can happen if all
logical channels of the requested type are busy, thus it is not a
error. Let's use LOGL_NOTICE for that.

Change-Id: I9b45852116253e5237b779a91bed8b800758360e
---
M src/osmo-bsc/lchan_select.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c
index 6df3b4a..d63db22 100644
--- a/src/osmo-bsc/lchan_select.c
+++ b/src/osmo-bsc/lchan_select.c
@@ -234,7 +234,7 @@
 		lchan->type = type;
 		LOG_LCHAN(lchan, LOGL_INFO, "Selected\n");
 	} else
-		LOG_BTS(bts, DRLL, LOGL_ERROR, "Failed to select %s channel\n",
+		LOG_BTS(bts, DRLL, LOGL_NOTICE, "Failed to select %s channel\n",
 			gsm_lchant_name(type));
 
 	return lchan;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15276
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9b45852116253e5237b779a91bed8b800758360e
Gerrit-Change-Number: 15276
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190827/f5aeea2f/attachment.html>


More information about the gerrit-log mailing list