This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15277 ) Change subject: abis_nm.c: handle_manufact_report(): use LOGP(), not LOGPC() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@314 PS1, Line 314: LOGPC(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr); The ones here look like they need fixing too. https://gerrit.osmocom.org/#/c/15277/1/src/osmo-bsc/abis_nm.c@344 PS1, Line 344: LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text); Don't we have LOGBTS or something similar? Or even better, pass foh as parameter and use LOGPFOH. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 Gerrit-Change-Number: 15277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2019 14:50:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/ce2fd7db/attachment.htm>