Change in osmo-trx[master]: add device type detection

Pau Espin Pedrol gerrit-no-reply at
Tue Apr 16 16:09:47 UTC 2019

Pau Espin Pedrol has posted comments on this change. ( )

Change subject: add device type detection

Patch Set 1:

File Transceiver52M/device/lms/LMSDevice.cpp:
PS1, Line 43: 
Since you dropped compat_functions, also drop this code from

AS_IF([test "x$with_lms" = "xyes"], [

    # LimeSuite dc124e4e2ed9b549b142410af172f0592f9f0c23 > 18.10 broke API compatibility:
            [[#include <lime/LimeSuite.h>]],
            [[LMS_VCTCXOWrite(NULL, 0, false); LMS_VCTCXORead(NULL, 0, false);]]
            [LMS_VCTCXO* requires memory parameter])],
            [LMS_VCTCXO* has no memory parameter])])
PS1, Line 181: 		LOGC(DDEV, ALERT) << "Invalid reference type";
ALERT is a logelvel inherited from osmo-trx and we slowly drop it. Better use ERROR.
PS1, Line 207: 			if (LMS_SetClockFreq(m_lms_dev, LMS_CLOCK_EXTREF, -1) < 0)
Should this NOT be EXTREF here? afaiu it should be internal one being set. Something's wrong here and you may need to re-check.
PS1, Line 225: 	/* set samplerate */
This comment and next one are unrelated, I'd love if you could move non-related stuff to different patch (these patches are complex enough with stuff being moved around).

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf905b0a84bc1ec200891762a6646141ee37181
Gerrit-Change-Number: 13663
Gerrit-PatchSet: 1
Gerrit-Owner: roh <jsteiger at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at>
Gerrit-Comment-Date: Tue, 16 Apr 2019 16:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list