Change in osmo-trx[master]: add device type detection

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 16 16:09:47 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13663 )

Change subject: add device type detection
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@43
PS1, Line 43: 
Since you dropped compat_functions, also drop this code from configure.ac:

AS_IF([test "x$with_lms" = "xyes"], [
    PKG_CHECK_MODULES(LMS, LimeSuite)

    # LimeSuite dc124e4e2ed9b549b142410af172f0592f9f0c23 > 18.10 broke API compatibility:
    _cflags_save=$CFLAGS
    CFLAGS="$CFLAGS $LMS_CFLAGS"
    AC_COMPILE_IFELSE(
        [AC_LANG_PROGRAM(
            [[#include <lime/LimeSuite.h>]],
            [[LMS_VCTCXOWrite(NULL, 0, false); LMS_VCTCXORead(NULL, 0, false);]]
        )],
        [AC_DEFINE([HAVE_LMS_VCTCXO_EEPROM_SAVING], [1],
            [LMS_VCTCXO* requires memory parameter])],
        [AC_DEFINE([HAVE_LMS_VCTCXO_EEPROM_SAVING], [0],
            [LMS_VCTCXO* has no memory parameter])])
    CFLAGS=$_cflags_save
])


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@181
PS1, Line 181: 		LOGC(DDEV, ALERT) << "Invalid reference type";
ALERT is a logelvel inherited from osmo-trx and we slowly drop it. Better use ERROR.


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@207
PS1, Line 207: 			if (LMS_SetClockFreq(m_lms_dev, LMS_CLOCK_EXTREF, -1) < 0)
Should this NOT be EXTREF here? afaiu it should be internal one being set. Something's wrong here and you may need to re-check.


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@225
PS1, Line 225: 	/* set samplerate */
This comment and next one are unrelated, I'd love if you could move non-related stuff to different patch (these patches are complex enough with stuff being moved around).



-- 
To view, visit https://gerrit.osmocom.org/13663
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf905b0a84bc1ec200891762a6646141ee37181
Gerrit-Change-Number: 13663
Gerrit-PatchSet: 1
Gerrit-Owner: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Apr 2019 16:09:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/4d510ee7/attachment.html>


More information about the gerrit-log mailing list