<p><a href="https://gerrit.osmocom.org/13663">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp">File Transceiver52M/device/lms/LMSDevice.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since you dropped compat_functions, also drop this code from configure.ac:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AS_IF([test "x$with_lms" = "xyes"], [<br>    PKG_CHECK_MODULES(LMS, LimeSuite)</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    # LimeSuite dc124e4e2ed9b549b142410af172f0592f9f0c23 > 18.10 broke API compatibility:<br>    _cflags_save=$CFLAGS<br>    CFLAGS="$CFLAGS $LMS_CFLAGS"<br>    AC_COMPILE_IFELSE(<br>        [AC_LANG_PROGRAM(<br>            [[#include <lime/LimeSuite.h>]],<br>            [[LMS_VCTCXOWrite(NULL, 0, false); LMS_VCTCXORead(NULL, 0, false);]]<br>        )],<br>        [AC_DEFINE([HAVE_LMS_VCTCXO_EEPROM_SAVING], [1],<br>            [LMS_VCTCXO* requires memory parameter])],<br>        [AC_DEFINE([HAVE_LMS_VCTCXO_EEPROM_SAVING], [0],<br>            [LMS_VCTCXO* has no memory parameter])])<br>    CFLAGS=$_cflags_save<br>])</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@181">Patch Set #1, Line 181:</a> <code style="font-family:monospace,monospace">            LOGC(DDEV, ALERT) << "Invalid reference type";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ALERT is a logelvel inherited from osmo-trx and we slowly drop it. Better use ERROR.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@207">Patch Set #1, Line 207:</a> <code style="font-family:monospace,monospace">                 if (LMS_SetClockFreq(m_lms_dev, LMS_CLOCK_EXTREF, -1) < 0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this NOT be EXTREF here? afaiu it should be internal one being set. Something's wrong here and you may need to re-check.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@225">Patch Set #1, Line 225:</a> <code style="font-family:monospace,monospace">   /* set samplerate */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment and next one are unrelated, I'd love if you could move non-related stuff to different patch (these patches are complex enough with stuff being moved around).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13663">change 13663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3cf905b0a84bc1ec200891762a6646141ee37181 </div>
<div style="display:none"> Gerrit-Change-Number: 13663 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: roh <jsteiger@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Apr 2019 16:09:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>