Change in osmo-trx[master]: add device type detection

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 16 15:26:27 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13663 )

Change subject: add device type detection
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.osmocom.org/#/c/13663/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13663/1//COMMIT_MSG@9
PS1, Line 9: device dependant max gain setup
again, please --verbose on why those changes are made. Nobody except you has all that context. thanks!


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@203
PS1, Line 203: ,11)==0){
", 11) == 0) {" [we love our spaces]


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@211
PS1, Line 211: else
             : 		if
we typically do "} else if {" in one line


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@416
PS1, Line 416: /FIXME crashes when called while stream is running
             : //>----do_calib(chan);
that shouldn't be part of the patch, I guess that was an accident?


https://gerrit.osmocom.org/#/c/13663/1/Transceiver52M/device/lms/LMSDevice.cpp@435
PS1, Line 435: //>----do_calib(chan);
that shouldn't be part of the patch, I guess that was an accident?



-- 
To view, visit https://gerrit.osmocom.org/13663
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf905b0a84bc1ec200891762a6646141ee37181
Gerrit-Change-Number: 13663
Gerrit-PatchSet: 1
Gerrit-Owner: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Tue, 16 Apr 2019 15:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/15bc5fa8/attachment.html>


More information about the gerrit-log mailing list