Change in libosmocore[master]: GSUP: add Class IE

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Apr 11 23:30:27 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13576 )

Change subject: GSUP: add Class IE
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h@309
PS3, Line 309: 	enum osmo_gsup_class		class;
Actually in this case I notice that the word 'class' alone is a keyword in C++, so it was in fact a poor choice for a variable / member name. So ... might have to format-patch-sed-git-am again <sigh>

This here would have been a saner place to argue against the name than above :P

I wish I had stayed firm with just using "Kind" instead, what's the use of changing synonyms for synonyms.



-- 
To view, visit https://gerrit.osmocom.org/13576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef
Gerrit-Change-Number: 13576
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/77b650eb/attachment.html>


More information about the gerrit-log mailing list