Change in libosmocore[master]: GSUP: add Class IE

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Apr 11 23:33:52 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13576 )

Change subject: GSUP: add Class IE
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c@481
PS3, Line 481: osmo_decode_big_endian
> It's just one byte, no need for osmo_decode_big_endian() here.
was just copying code I saw elsewhere; you are right though, I think I copied uint32_t code without noticing.


https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c@739
PS3, Line 739: {}
> Common style: { 0, NULL }
I always use {}, and have been doing that all over the place.



-- 
To view, visit https://gerrit.osmocom.org/13576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef
Gerrit-Change-Number: 13576
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 11 Apr 2019 23:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/62e5c79c/attachment.html>


More information about the gerrit-log mailing list