This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11138 ) Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH ...................................................................... Patch Set 2: (5 comments) https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c File src/host/trxcon/sched_prim.c: https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@a372 PS2, Line 372: > Interesting. […] It was a dirty hack to make both TTCN-3 and OsmoBTS happy ;) https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@180 PS2, Line 180: prim->payload[0] = trx->tx_power; > I think this should be done (without if 0) in line 172, in the dummy meas rep case. Please see the above comment. I am going to change it to use the actual values, but for the "dummy" MRs only. https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@192 PS2, Line 192: LOGP(DSCHD, LOGL_NOTICE, "Transmitting a %s Measurement Report " > We are not transmitting here. […] Thanks! "Using" looks good to me. https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@234 PS2, Line 234: mr_now = !lchan->sacch.mr_tx_last; > With this toggle and above coment from "sub-clause 3.4. […] I don't know what do you mean by "SACCH slots". If you mean the sub-slots (e.g. TRXC_SACCH4_0 that accomplishes TRXC_SDCCH4_0), this function itself handles each one individually. The idea of this flag is to determine, *what can be transmitted* at the moment depending on what was transmitted last time: - if a Measurement Report was transmitted last time, we can then either transmit something else (i.e. not a MR), or again a Measurement Report if there are no other SACCH messages. - if a Measurement Report was not transmitted last time, we can transmit a Measurement Report only. This simple logic implements the requirement from sub-clause 3.4.1. https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@259 PS2, Line 259: if (mr_now && prim_mr) > This if-else clause can be merged into previous 2 ifs, and it's way clear imho. […] Let's leave it as is for now. For me, the nested conditions here would look a bit more complicated than it's now. -- To view, visit https://gerrit.osmocom.org/11138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d Gerrit-Change-Number: 11138 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 10:46:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/50ac5718/attachment.htm>