Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Sep 28 10:22:30 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@143
PS2, Line 143: "Dummy" Measurement Report
> should the L1 SACCH header even of the dummy not contain the actual MS power level that is used / th […]
Hmm, I think it should. Good point, thanks!

Let's use the actual TA and PWR values at least for the "dummy" ones.
It could be also great to have actual values in the cached reports,
but trxcon doesn't know about the intentions of the higher layers,
i.e. whether the distance spoofing enabled or not.

If the higher layers would indicate spoofing, e.g. as a part of the
L1CTL_PARAM_REQ message, we could decide here...



-- 
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/e3844389/attachment.htm>


More information about the gerrit-log mailing list