Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Sep 28 10:50:39 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@259
PS2, Line 259: 		if (mr_now && prim_mr)
> Let's leave it as is for now. For me, the nested conditions […]
Getting rid of prim_mr and prim_nmr can make this function half size of what it is now, but fine for me.

There's no need for those two variables since you always seek only 1 prim object and its value is known just by looking at "mr_now" and checking it's not NULL.



-- 
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:50:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/53106896/attachment.htm>


More information about the gerrit-log mailing list