Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11365 )

Change subject: jenkins-common.sh: add docker_images_require()
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11365/2/jenkins-common.sh
File jenkins-common.sh:

https://gerrit.osmocom.org/#/c/11365/2/jenkins-common.sh@8
PS2, Line 8: 		if [ -z "$NO_DOCKER_IMAGE_BUILD" ]; then
btw, in general, it is better to avoid double negation / positive meaning negative in settings like these. i.e.

  do_this = [true|false]

is easier to grok than

  dont_do_this = [true|false]

Then a default of 1:

  DOCKER_IMAGE_BUILD="${DOCKER_IMAGE_BUILD:-1}"

again not that important, but keep in mind for next time maybe.



-- 
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181017/762c4cef/attachment.htm>