Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11365 )

Change subject: jenkins-common.sh: add docker_images_require()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh
File jenkins-common.sh:

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh@5
PS1, Line 5: docker_images_require() {
> In this commit, yes. But the next commit it will be used from all jenkins.sh files. […]
On the one hand we want atomic commits, i.e. as small as makes sense. But it doesn't make sense to add dead code that no-one uses. Sometimes it is desirable to separate patches like this, but then the commit log should explicitly state which other change-id it prepares for.

For new functions, understanding the semantics usually requires to see how the callers invoke the new function. So yea, this would qualify for squashing with the patch that adds a caller.



-- 
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Oct 2018 13:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181017/329eb20e/attachment.htm>