<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/11365">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11365/2/jenkins-common.sh">File jenkins-common.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11365/2/jenkins-common.sh@8">Patch Set #2, Line 8:</a> <code style="font-family:monospace,monospace">          if [ -z "$NO_DOCKER_IMAGE_BUILD" ]; then</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">btw, in general, it is better to avoid double negation / positive meaning negative in settings like these. i.e.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  do_this = [true|false]</pre><p style="white-space: pre-wrap; word-wrap: break-word;">is easier to grok than</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  dont_do_this = [true|false]</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Then a default of 1:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  DOCKER_IMAGE_BUILD="${DOCKER_IMAGE_BUILD:-1}"</pre><p style="white-space: pre-wrap; word-wrap: break-word;">again not that important, but keep in mind for next time maybe.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11365">change 11365</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11365"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1 </div>
<div style="display:none"> Gerrit-Change-Number: 11365 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Oct 2018 13:38:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>