osmo-hlr[master]: cosmetic: refactor auc_compute_vectors(), add debug log

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 23 14:16:41 UTC 2017


Patch Set 1:

> (1 comment)
 > 
 > > I understand the need for debug logging during development, but I
 > > think for normla use this is rather on the excessive side,
 > 
 > which is why I added the local flag that pre-fetches whether debug
 > logging is enabled, so that we basically just have a dozen "if (0)"
 > in case debug logging is off. Is that not sufficient?

No.  I think "DEBUG" should be for debugging of issues in production, not for debugging issues during initial development of the code.  I think it is highly unlikely that anyone would want to see all the nitty-gritty details of the calculation in production use.  I think this level of detail goes much beyond the usual level of detail we have with LOGL_DEBUG in other code.  But then, maybe my feeling is wrong here?

-- 
To view, visit https://gerrit.osmocom.org/1869
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d010a4ac64c765517e15b9074424ec19cc60
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list