osmo-hlr[master]: cosmetic: refactor auc_compute_vectors(), add debug log

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Feb 23 21:25:45 UTC 2017


Patch Set 1:

> No.  I think "DEBUG" should be for debugging of issues in
 > production, not for debugging issues during initial development of
 > the code.  I think it is highly unlikely that anyone would want to
 > see all the nitty-gritty details of the calculation in production
 > use.

Maybe my perspective is skewed because I'm neck deep in the milenage and auth API nitty-gritty, at least at the moment I find it comforting to be able to switch on debugging on a production HLR and see what numbers it actually produced before going over the wire -- without having to recompile first. I think the few 'if (0)' in case debugging is off are sufficient to justify it. I accept though that I may find this too detailed myself once the certainty that all the algorithms and APIs around them are correct has settled. So now we need a decision... if you or anyone else confirms that it's too much for a run-time, I will disagree now (but most probably will never look back either) and change the patch. Make me do it though :)

-- 
To view, visit https://gerrit.osmocom.org/1869
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d010a4ac64c765517e15b9074424ec19cc60
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list