osmo-hlr[master]: cosmetic: refactor auc_compute_vectors(), add debug log

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 22 15:06:16 UTC 2017


Patch Set 1:

(1 comment)

> I understand the need for debug logging during development, but I
 > think for normla use this is rather on the excessive side,

which is why I added the local flag that pre-fetches whether debug logging is enabled, so that we basically just have a dozen "if (0)" in case debug logging is off. Is that not sufficient?

https://gerrit.osmocom.org/#/c/1869/1/src/auc.c
File src/auc.c:

Line 44: 	/* no need to iterate the log categories all the time */
here:


-- 
To view, visit https://gerrit.osmocom.org/1869
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d010a4ac64c765517e15b9074424ec19cc60
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list