osmo-hlr[master]: cosmetic: refactor auc_compute_vectors(), add debug log

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 22 07:21:08 UTC 2017


Patch Set 1: Code-Review-1

I understand the need for debug logging during development, but I think for normla use this is rather on the excessive side, and I would probably go for a compile-time define for this level of verbosity, to avoid dozens of debug-printing calls during every auth vector generation (which is the most common operations for a HLR/AUC).

-- 
To view, visit https://gerrit.osmocom.org/1869
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb36d010a4ac64c765517e15b9074424ec19cc60
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


More information about the gerrit-log mailing list