[PATCH] COMP128v23 improvements

Max.Suraev at fairwaves.ru
Tue Nov 19 09:33:01 UTC 2013


19.11.2013 09:17, Sylvain Munaut пишет:
> Hi Max,
> 
> There are definitely things weird in that patch :
> 
>  - You double declare the same function

Which one?

>  - Why replace #defined constant by hardcoded numbers ?

To make code look more similar to comp128v1 and other code which uses Kc and rand: we
use hardcoded values everywhere.


>  - Speaking about readability :
> 
> kc[6] = 4 * (kc[6] >> 2);
> 
> isn't the most obvious way to do kc[6] &= 0xfc;

Added, thank you.


-- 
best regards,
Max, http://fairwaves.ru


More information about the baseband-devel mailing list