[PATCH] COMP128v23 improvements
246tnt at gmail.com
Tue Nov 19 08:17:26 UTC 2013
There are definitely things weird in that patch :
- You double declare the same function
- Why replace #defined constant by hardcoded numbers ?
- Speaking about readability :
kc = 4 * (kc >> 2);
isn't the most obvious way to do kc &= 0xfc;
On Mon, Nov 18, 2013 at 6:47 PM, ☎ <Max.Suraev at fairwaves.ru> wrote:
> I've got rid of unnecessary cycle and to made difference between v2 and v3 more
> visible: v2 is basically just v3 with last bits of Kc zeroed. Also - small
> readability improvements.
> Also I've added test suite with test vectors from original python implementation.
> best regards,
> Max, http://fairwaves.ru
More information about the baseband-devel