Some Patch files

Bhaskar11 niceguy108 at gmail.com
Mon May 20 06:57:10 UTC 2013


Three few more patches. Hope these are better done.

B.



On Sat, May 18, 2013 at 3:07 PM, Sylvain Munaut <246tnt at gmail.com> wrote:

> On Sat, May 18, 2013 at 11:13 AM, Holger Hans Peter Freyther
> <holger at freyther.de> wrote:
> > On Sat, May 18, 2013 at 10:59:25AM +0530, Bhaskar11 wrote:
> >> Two more bugfix patches. Please give me feedback if these patches are
> >> working ok.
> >
> > thanks, i will attempt to review/merge them over the next couple
> > of days.
>
>
> I had a quick look at the last two, but I'm not convinced, I'll
> probably rewrite a fix for those.
>
> 1) There is actually 3 places where trans_assign_trans_id is used and
> the one that's correct uses 'int' and not 'int8_t' and this seems a
> better approach because that's the native return type of the
> trans_assign_trans_id function. This way we have 'int' (return value
> allowing full valid range of uint8_t + negative values for error) and
> 'uint8_t' ( final valid value stored in structure ), and we avoid
> going from int -> int8_t -> uint8_t. And as a bonus the three places
> in the code with this pattern are now consistent with each other.
>
> 2) The patch title is wrong :
>   - It actually says "should be unsigned int to allow negative values"
>   - It's also too long and doesn't include an indication of the
> subsystem it refers to.
>
> 3) IMHO, Those two patches are trivial and similar enough to have been
> made in one commit.
>
> I've attached as an example the corrected patch I will apply, for
> future reference.
>
> I'll probably get to the other later in the day.
>
> Cheers,
>
>     Sylvain
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20130520/673a6c5b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bugfix-correction-to-printf-format-specifier.patch
Type: application/octet-stream
Size: 738 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20130520/673a6c5b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bugfix-in-app_mobile.c-added-error-checking-in-l23_a.patch
Type: application/octet-stream
Size: 1190 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20130520/673a6c5b/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-app_mobile.h-extern-added-to-config_dir-to-prevent-d.patch
Type: application/octet-stream
Size: 910 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20130520/673a6c5b/attachment-0002.obj>


More information about the baseband-devel mailing list