[PATCH 8/8] firmware: mark some structs as packed
laforge at gnumonks.org
Thu Nov 24 08:40:19 UTC 2011
Hi Sylvain and Alexander,
On Thu, Nov 24, 2011 at 07:58:33AM +0100, Sylvain Munaut wrote:
> First, thanks for this series of patch, I'll be sure to review and test them.
Thanks for testing, Sylvain.
> > -};
> > +} __packed;
> I'm not conviced by this one : Why should we use packed for structures
> not used as 'communication packets' ?
I agree with Sylvain here. this will just cause the compiler to
generate much less efficient code at no other benefit...
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
More information about the baseband-devel