[PATCH 8/8] firmware: mark some structs as packed

Sylvain Munaut 246tnt at gmail.com
Thu Nov 24 06:58:33 UTC 2011


Hi,

First, thanks for this series of patch, I'll be sure to review and test them.

> this eliminates the occurrance of gcc warning
> warning: cast increases required alignment of target type
> ---
>  src/target/firmware/include/comm/timer.h           |    4 +++-
>  src/target/firmware/include/layer1/sched_gsmtime.h |    5 ++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)

> -};
> +} __packed;

I'm not conviced by this one : Why should we use packed for structures
not used as 'communication packets' ?

Cheers,

     Sylvain




More information about the baseband-devel mailing list