[PATCH libosmocore] gsm 03.41: fix GSM341_MSG_CODE macro argument

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/baseband-devel@lists.osmocom.org/.

Alex Badea vamposdecampos at gmail.com
Sat Jan 15 17:43:42 UTC 2011


One usage of the "ms" argument is typoed as "msg".  Fix it to prevent
subtle future failures.  Also paranthesize the macro argument for good
measure.

Signed-off-by: Alex Badea <vamposdecampos at gmail.com>
---
This was found by visual inspection.

 include/osmocore/protocol/gsm_03_41.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/osmocore/protocol/gsm_03_41.h b/include/osmocore/protocol/gsm_03_41.h
index 3b1b7c9..54365cb 100644
--- a/include/osmocore/protocol/gsm_03_41.h
+++ b/include/osmocore/protocol/gsm_03_41.h
@@ -40,7 +40,7 @@ struct gsm341_etws_message {
 	uint8_t data[0];
 } __attribute__((packed));
 
-#define GSM341_MSG_CODE(ms) (ms->serial.code_lo | (msg->serial.code_hi << 4))
+#define GSM341_MSG_CODE(ms) ((ms)->serial.code_lo | ((ms)->serial.code_hi << 4))
 
 /* Section 9.3.2.1 - Geographical Scope */
 #define GSM341_GS_CELL_WIDE_IMMED	0
-- 
1.7.0.4





More information about the baseband-devel mailing list