[PATCH] src: use new libosmogsm and include/osmocom/[gsm|core] path to headers

Pablo Neira Ayuso pablo at gnumonks.org
Tue Apr 26 15:43:14 UTC 2011


On 26/04/11 14:34, Harald Welte wrote:
> Hi Pablo,
> 
> thanks a lot.  I took the liberty of merging your patch, as it seemed
> to build+work fine here.

Thanks Harald.

> In a more general sense, I think the more stable the API of libosmocore
> becomes, the less need we have for copying libosmocore inside osmocom-bb.git
> by means of git-subtree.
> 
> This was mainly a hack early on, to decouple osmocom-bb from the API
> instabilities and build errors when cross-compiling for the target ARM.
> 
> If we'd start to make official libosmocore releases, we can simply
> base on that.  The cross-compilation for the target could be handled
> by a script that will download the respective libosmocore snapshot
> (or latest git master), and then run configure + make.

Indeed, this makes sense.

BTW, I'll start with the patches that fix the namespace pollution
(adding osmo_* to all functions and such). In order to reduce the
clashes with other ongoing patches, I'll send this change in several
series that include small chucks (ie. first all select.c functions and
structures start by osmo_*, then signal.c, and so on). Let me know if
you think this is excessive.




More information about the baseband-devel mailing list