This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-net-gprs@lists.osmocom.org/.
David Miller davem at davemloft.netFrom: Andreas Schultz <aschultz at tpip.net>
Date: Mon, 13 Feb 2017 16:36:18 +0100
> + if (gtp->sk0) {
> + udp_sk(gtp->sk0)->encap_type = 0;
> + rcu_assign_sk_user_data(gtp->sk0, NULL);
> + sock_put(gtp->sk0);
> }
This does "sock_put(NULL);" because you are assigning gtp->sk0 to
NULL before the sock_put() call. So you are leaking the socket,
at best.
You need to load the socket pointer into a local variable in order
to do this correctly.